Userid module: propagate ortb2.user.ext.eids to userIdsAsEids even if no UserId submodules #12477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like there are some test failures this change causes - we are looking into them. |
It's on our end. Pr up to fix issue |
|
Try merging in Master |
patmmccann
changed the title
dgirardi
reviewed
Nov 21, 2024
modules/userId/index.js
Outdated
| @@ -1211,6 +1223,10 @@ export function init(config, {delay = GreedyPromise.timeout} = {}) { | |||
| initIdSystem({ready: true}); | |||
| } | |||
| } | |||
| if (!addedUserIdHook && !startAuction.getHooks({hook: addUserIdsHook}).length) { | |||
There was a problem hiding this comment.
I'd put it outside of the config listener - like this. Do you have a reason to prefer it here? I'm thinking that without any submodules, you wouldn't get any configuration either.
dgirardi
approved these changes
Nov 22, 2024
patmmccann
approved these changes
Nov 23, 2024
hogekai
pushed a commit
to hogekai/Prebid.js
that referenced
this pull request
Nov 26, 2024
… no UserId submodules (prebid#12477) * userId module: temp fix empty bid.userIdAsEids * userId module: fix empty bid.userIdAsEids * userId module: fix empty bid.userIdAsEids * userId module: fix empty bid.userIdAsEids * userId module: fix tests * userId module: prevent re-adding addUserIdsHook hook * userId module: mode adding addUserIdsHook, added test --------- Co-authored-by: Konstantin Mikhalyov <[email protected]> Co-authored-by: Bohdan V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Addresses #12458 - we've spotted the issue that if there are no UserId submodules added - the
bidRequest.userIdsAsEidsis empty, while some bid adapters peak into it instead ofortb2.user.ext.eids. This PR addresses this issue by adding calling corresponding hook that would propagate eids intobidRequest.userIdsAsEidsregardless of the submodules presence.