-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IntentIq ID & Analytics Modules : support domainName parameter #12434
Merged
Rothalack
merged 24 commits into
prebid:master
from
DimaIntentIQ:AGT-374-support-domain-name-in-prebid-module
Nov 22, 2024
Merged
IntentIq ID & Analytics Modules : support domainName parameter #12434
Rothalack
merged 24 commits into
prebid:master
from
DimaIntentIQ:AGT-374-support-domain-name-in-prebid-module
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntentIq: manual reporting, bug fixes, refactoring.
dmytro-po
changed the title
IntentIq ID: Support domainName parameter
IntentIq ID & Analytics Modules: Support domainName parameter
Nov 12, 2024
ChrisHuie
changed the title
IntentIq ID & Analytics Modules: Support domainName parameter
IntentIq ID & Analytics Modules : support domainName parameter
Nov 12, 2024
2 tasks
Rothalack
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works in testing
hogekai
pushed a commit
to hogekai/Prebid.js
that referenced
this pull request
Nov 26, 2024
…d#12434) * update intentIqAnalyticsAdapter.js && intentIqIdSystem.js * fix lint issues * fix tests * move info * resolve issues * update storeFirstPartyData * remove unused code * update defineEmptyDataAndFireCallback * update fix lint * update reportExternalWin * small fixes * update test && add docs * AGT-347: Support domain name * AGT-347: Support domain name * AGT-374: Support domainName to vrref * AGT-374: tests in progress * AGT-374: Remove duplicate encoded in getRelevantRefferer and fix tests * AGT-374: Add test domainName, changes in documentation * AGT-374: Change js version value * AGT-374: Remove extra coma * Remove unused method --------- Co-authored-by: dlepetynskyi <[email protected]> Co-authored-by: DimaIntentIQ <[email protected]> Co-authored-by: DimaIntentIQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Support for domainName provided by the partner. It specifies the domain of the page where the IntentIQ object is currently running and serving the impression. This feature also resolves a bug related to a missing referrer when access to the
window
object is blocked within an iframe.