Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51Degrees RTD submodule: optimise ORTB2 enrichment speed #12394

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

jwrosewell
Copy link
Contributor

Type of change

  • Updated RTD submodule

Description of change

This pull request optimises the ORTB2 enrichment speed for the 51Degrees RTD submodule by eliminating a redundant API call. The changes allow for some device details to be sent directly in the first request, instead of making a second call to the 51Degrees API HTTP endpoint.

  • Refactored the get51DegreesJSURL function to include device details such as screen height, width, HEV, and pixel ratio directly in the JS request query string.
  • Introduced a new function to retrieve high entropy values from navigator.userAgentData, if supported.
  • Updated relevant tests to ensure the new functionality works as intended and to validate the inclusion of device details in the API request.

@ChrisHuie
Copy link
Collaborator

looks like there is a failing unit test

@BohdanVV
Copy link
Contributor

BohdanVV commented Nov 6, 2024

looks like there is a failing unit test

Thanks, @ChrisHuie. I've fixed the tests.

@ChrisHuie ChrisHuie self-requested a review November 12, 2024 15:29
@ChrisHuie ChrisHuie self-assigned this Nov 12, 2024
@ChrisHuie ChrisHuie merged commit e16c01f into prebid:master Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants