Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kargo Bid Adapter: replaces triggerPixel with fetch #12387

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

nickllerandi
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Refactors onTimeout to use fetch instead of triggerPixel

* replaces triggerPixel with fetch

* replaces triggerPixel test
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@nickllerandi
Copy link
Contributor Author

Acknowledging the flag for duplicate code. I can investigate that as part of this PR if preferred. Would just take me a few days. Preference would be to flag this internally and can followup with a ticket to address.

@patmmccann
Copy link
Collaborator

we'll keep an eye out for the follow up, thanks Nick!

@patmmccann patmmccann self-assigned this Oct 30, 2024
@patmmccann patmmccann merged commit 16642a5 into prebid:master Oct 30, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants