Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ehealthcaresolutions Bid Adapter : initial release #12384

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

pranavsheth
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@ChrisHuie ChrisHuie self-requested a review October 31, 2024 12:30
@ChrisHuie ChrisHuie self-assigned this Oct 31, 2024
return getBannerRequest(bidRequests, serverRequest, ENDPOINT_URL);
},
// Unpack the response from the server into a list of bids.
interpretResponse: (bResponse, bRequest) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an opportunity to import this as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patmmccann
we used same repo for both the bidders. Tapnative is already merged, now we want to add same for ehealthcaresolutiosn. and we are alraedy using common library for both.

Thanks

@ChrisHuie
Copy link
Collaborator

Can you please add documentation for both of these adapters in our docs repo -> https://github.com/prebid/prebid.github.io

@pranavsheth
Copy link
Contributor Author

Can you please add documentation for both of these adapters in our docs repo -> https://github.com/prebid/prebid.github.io

Hi @ChrisHuie
we already had PR for tapnative, it is merged. I have created new PR for ehealthcaresolutions - prebid/prebid.github.io#5686

@ChrisHuie
Copy link
Collaborator

@pranavsheth can you please pull in the master branch. This fork is a bit behind and doesn't include tapnative being merged in master

@ChrisHuie ChrisHuie changed the title new bidder:ehealthcaresolutions ehealthcaresolutions Bid Adapter : initial release Nov 4, 2024
@pranavsheth
Copy link
Contributor Author

@pranavsheth can you please pull in the master branch. This fork is a bit behind and doesn't include tapnative being merged in master

Hi @ChrisHuie
we created this fork for tapnative and tapnative code is merged in master. Now we have used the same fork for this new adapter. so code is already upto date.

@ChrisHuie
Copy link
Collaborator

@pranavsheth can you please pull in the master branch. This fork is a bit behind and doesn't include tapnative being merged in master

Hi @ChrisHuie we created this fork for tapnative and tapnative code is merged in master. Now we have used the same fork for this new adapter. so code is already upto date.

Yeah. Didn't realize one of these adapters is already in master because the fork is behind and says you are adding both adapters in this pr. Please pull in master to resolve this discrepancy.

@pranavsheth
Copy link
Contributor Author

@pranavsheth can you please pull in the master branch. This fork is a bit behind and doesn't include tapnative being merged in master

Hi @ChrisHuie we created this fork for tapnative and tapnative code is merged in master. Now we have used the same fork for this new adapter. so code is already upto date.

Yeah. Didn't realize one of these adapters is already in master because the fork is behind and says you are adding both adapters in this pr. Please pull in master to resolve this discrepancy.

HI @ChrisHuie
as suggested we have pulled from master to resolve this discrepancy. pl check and merged to master if everything is fine.
thanks.

@ChrisHuie ChrisHuie removed the on hold label Nov 14, 2024
@ChrisHuie ChrisHuie merged commit 62307a3 into prebid:master Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants