Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bid adapter: Adverxo #12376

Merged
merged 6 commits into from
Nov 15, 2024
Merged

New bid adapter: Adverxo #12376

merged 6 commits into from
Nov 15, 2024

Conversation

dev-adverxo
Copy link
Contributor

@dev-adverxo dev-adverxo commented Oct 28, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

  • contact email of the adapter’s maintainer: [email protected]

  • test parameters for validating bids:

var adUnits = [
    {
        code: 'div-gpt-ad-1460505748561-0',
        mediaTypes: {
            banner: {
                sizes: [300, 250]
            }
        },
        bids: [{
            bidder: 'adverxo',
            params: {
                host: "stresda.com",
                adUnitId: 41358,
                auth: "61336e75e414c77c367de5c47c2599ce80a8032b"
            }
        }]
    },
    {
        code: 'native-div',
        mediaTypes: {
            native: {
                sendTargetingKeys: false,
                title: {
                    required: true,
                    len: 800
                },
                body: {
                    required: false,
                },
                image: {
                    required: true
                },
                cta: {
                    required: false
                }
            }
        },
        bids: [{
            bidder: 'adverxo',
            params: {
                host: "stresda.com",
                adUnitId: 41359,
                auth: "9a640dfccc3381e71f0c29ffd4a72eabd29d9d86"
            }
        }]
    },
    {
        code: 'div-gpt-ad-1460505748561-1',
        mediaTypes: {
            video: {
                context: 'outstream', // or 'outstream',
                mimes: ['video/mp4'],
                playerSize: [1280, 720] // video player size
            }
        },
        // Replace this object to test a new Adapter!
        bids: [{
            bidder: 'adverxo',
            params: {
                host: "stresda.com",
                adUnitId: 41939,
                auth: "7813bfb2ebe04b8723a534021e3f7ddc5fcdf71c"
            }
        }],
        renderer: {
            url: "https://acdn.adnxs.com/video/outstream/ANOutstreamVideo.js",
            render: (bid) => {
                let ad = bid.ad || bid.vastXml;

                const adResponse = {
                    ad: {
                        video: {
                            content: ad,
                            player_width: 640,
                            player_height: 480,
                        }
                    }
                }

                bid.renderer.push(() => {
                    window.ANOutstreamVideo.renderAd({
                        targetId: bid.adUnitCode,
                        adResponse,
                    });
                });
            }
        }
    }
];

Other information

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host cannot be a required parameter. It is incredibly awkward for publishers to have to enter a hostname on thousands of adunits when this is a global config.

Introduce new aliases and an auction url for each.
We will also have the aliseses in pbs.
@dev-adverxo
Copy link
Contributor Author

host cannot be a required parameter. It is incredibly awkward for publishers to have to enter a hostname on thousands of adunits when this is a global config.

Fixed. We introduce new aliases with default url for ours partners.

@bretg bretg removed their request for review November 8, 2024 14:00
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is limited to confirming that the host parameter is no longer required.

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in testing, looks good!

@Rothalack Rothalack merged commit a9de3c1 into prebid:master Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants