gptPreAuction: fix missing gpid when using mcmEnabled #12361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
approved these changes
Oct 23, 2024
|
@ChrisHuie am I allowed to merge? |
muuki88
reviewed
Oct 23, 2024
| @@ -190,9 +194,9 @@ export const makeBidRequestsHook = (fn, adUnits, ...args) => { | |||
| let adserverSlot = deepAccess(context, 'data.adserver.adslot'); | |||
| let result; | |||
| if (customPreAuction) { | |||
| result = customPreAuction(adUnit, adserverSlot); | |||
| result = customPreAuction(adUnit, adserverSlot, adUnitPaths?.[adUnit.code]); | |||
There was a problem hiding this comment.
The conditional chaining was missing before, right?
There was a problem hiding this comment.
Correct. Without it,
Prebid.js/modules/gptPreAuction.js
Line 70 in 91587a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Resubmit of #12356, which included its own bug.