Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permutive Identity Manager: initial implementation #12337

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

talbotja
Copy link
Contributor

@talbotja talbotja commented Oct 17, 2024

Type of change

  • Bugfix

  • Feature (new userId submodule)

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

This PR adds a new userId submodule, permutiveIdSystem, which will support Permutive customers in using Permutive's Identity Manager product.

The basic idea is that Permutive's customer can configure which identity providers they want to work with via Permutive's dashboard, and Permutive's SDK, running on the customer's site, will take care of retrieving the relevant IDs and storing them in localStorage. The job of this module is to take those IDs from localStorage and make them available to prebid bidders.

modules/permutiveIdSystem.js Outdated Show resolved Hide resolved
modules/permutiveIdSystem.js Outdated Show resolved Hide resolved
modules/permutiveIdSystem.js Outdated Show resolved Hide resolved
modules/permutiveIdSystem.js Outdated Show resolved Hide resolved

primaryIds: PRIMARY_IDS,

eids: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question to prebid maintainers, if we were to make this a getter property such that we could read the eids config directly from our SDK and use what we have defined here as a fallback, would this propagate to other parts of the identity system as it would be called frequently? Or is the initial object returned stored by reference somewhere?

i.e.

get eids() {
  const data = read.from.permutive.sdk
  if (data) {
    return data
  }

  return { id5id: ... }
}

test/spec/modules/permutiveIdSystem_spec.js Outdated Show resolved Hide resolved
@talbotja talbotja marked this pull request as ready for review October 17, 2024 20:23
emphasizes that permutive is not actually providing any IDs itself
Copy link
Collaborator

@JulieLorin JulieLorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie merged commit 6fc52d6 into prebid:master Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants