Richaudience Bid Adapter : add gvlid to alias #12330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prebid.js doesn't use the `spec.gvlid` for aliases as it seems. In order to avoid `gvlMapping` definitions, the shorter alias also gets a gvlid
Ahhh :D |
|
@ChrisHuie can you restart the test pipeline? it seems to have timed out |
ChrisHuie
changed the title
ChrisHuie
approved these changes
Oct 18, 2024
pdamoc
pushed a commit
to missena-corp/Prebid.js
that referenced
this pull request
Oct 22, 2024
* add gvlid to alias Prebid.js doesn't use the `spec.gvlid` for aliases as it seems. In order to avoid `gvlMapping` definitions, the shorter alias also gets a gvlid * Fix alias test * Use deep equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Prebid.js doesn't use the
spec.gvlidas a fallback foraliases. This change makes the rich audience adapter work out-of-the-box if theraaliases is used.Without this change a
gvlMappingdefinition ( https://docs.prebid.org/dev-docs/modules/tcfControl.html#page-integration ) would be required.Other information