Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missena Bid Adapter : send schain & uspConsent #12296

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

pdamoc
Copy link
Contributor

@pdamoc pdamoc commented Oct 7, 2024

Type of change

  • Updated bidder adapter

Description of change

The update sends the schain and the upsConsent to our servers.

The section of code that builds the payload that our servers expect has been refactored (extracted) to an helper function.

There are also some updates to the documentation of the function @params required to get rid of the jdoc warnings that the adapter was throwing.

@ChrisHuie ChrisHuie changed the title Missena Bid Adapter send schain & uspConsent Missena Bid Adapter : send schain & uspConsent Oct 7, 2024
@pdamoc
Copy link
Contributor Author

pdamoc commented Oct 9, 2024

Are the tests added in c61eefe sufficient?

@ChrisHuie ChrisHuie self-assigned this Oct 10, 2024
@ChrisHuie ChrisHuie merged commit 169638e into prebid:master Oct 10, 2024
4 of 5 checks passed
@bretg
Copy link
Collaborator

bretg commented Oct 11, 2024

@pdamoc - FWIW, I can't get your colleague to look at the Missena docs PR that's been stuck for months prebid/prebid.github.io#5437

pdamoc added a commit to missena-corp/Prebid.js that referenced this pull request Oct 22, 2024
* Missena bidAdapter send schain & us_privacy

* Add tests for new payload fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants