-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Incorrect generation of analytics impression url when bid response is a VAST URL (videoTrackers.js) #12252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckers.js module.Getting object Required Array<string>.
shubham-si
changed the title
Fixed issue of adding analytics impression pixel via Prebid's vastTra…
Fixed issue of adding analytics impression pixel via Prebid's vastTrackers.js module.Getting object Required Array
Sep 18, 2024
shubham-si
changed the title
Fixed issue of adding analytics impression pixel via Prebid's vastTrackers.js module.Getting object Required Array
Fixed issue of adding analytics impression pixel via Prebid's vastTrackers.js module. Getting object Required Array
Sep 18, 2024
shubham-si
changed the title
Fixed issue of adding analytics impression pixel via Prebid's vastTrackers.js module. Getting object Required Array
Fixed issue of adding analytics impression pixel via Prebid's vastTrackers.js module. Getting object Required Array<String>
Sep 18, 2024
shubham-si
changed the title
Fixed issue of adding analytics impression pixel via Prebid's vastTrackers.js module. Getting object Required Array<String>
vastTrackers module : Incorrect CDATA Generation of Impression Trackers for Video having vastUrl as response. Getting Set<Array.String> Required Array<String>.
Sep 18, 2024
shubham-si
changed the title
vastTrackers module : Incorrect CDATA Generation of Impression Trackers for Video having vastUrl as response. Getting Set<Array.String> Required Array<String>.
Fix: Incorrect formation of analytics impression url's for video responses via vastTrackers.js module. Getting Set<Array.string> Required string|Array for videoCache module.
Sep 18, 2024
shubham-si
changed the title
Fix: Incorrect formation of analytics impression url's for video responses via vastTrackers.js module. Getting Set<Array.string> Required string|Array for videoCache module.
Fix: Incorrect formation of analytics impression url's for video responses via vastTrackers.js module. Getting Set<Array.string> Required string|Array<string>.
Sep 18, 2024
shubham-si
changed the title
Fix: Incorrect formation of analytics impression url's for video responses via vastTrackers.js module. Getting Set<Array.string> Required string|Array<string>.
Fix: Incorrect formation of analytics impression url's for video responses via vastTrackers.js module.
Sep 18, 2024
shubham-si
changed the title
Fix: Incorrect formation of analytics impression url's for video responses via vastTrackers.js module.
Fix: Incorrect concatenation of analytics impression url's to video vastImpUrl via videoTrackers.js module.
Sep 18, 2024
shubham-si
changed the title
Fix: Incorrect concatenation of analytics impression url's to video vastImpUrl via videoTrackers.js module.
Fix: Incorrect generation of analytics impression url's to video vastImpUrl via videoTrackers.js module.
Sep 18, 2024
shubham-si
changed the title
Fix: Incorrect generation of analytics impression url's to video vastImpUrl via videoTrackers.js module.
Fix: Incorrect generation of vast impression trackers having vastUrl as video response via videoTrackers.js module.
Sep 18, 2024
shubham-si
changed the title
Fix: Incorrect generation of vast impression trackers having vastUrl as video response via videoTrackers.js module.
Fix: Incorrect generation of analytics impression url when bid response is a VAST URL (videoTrackers.js)
Sep 18, 2024
Hey @patmmccann , could you please check this MR since you have defined the spec. |
I tried adding a test case for this but I am unable to update this PR. Could you either add a test yourself, or merge in ab3bb90 ? Thanks! |
@dgirardi can we merge this |
patmmccann
approved these changes
Oct 7, 2024
dgirardi
approved these changes
Oct 7, 2024
anand-nexverse
pushed a commit
to anand-nexverse/Prebid.js
that referenced
this pull request
Oct 8, 2024
…se is a VAST URL (videoTrackers.js) (prebid#12252) * Fixed issue of adding analytics impression pixel via Prebid's vastTrackers.js module.Getting object Required Array<string>. * Add test --------- Co-authored-by: shubham.si <[email protected]> Co-authored-by: Demetrio Girardi <[email protected]>
pdamoc
pushed a commit
to missena-corp/Prebid.js
that referenced
this pull request
Oct 22, 2024
…se is a VAST URL (videoTrackers.js) (prebid#12252) * Fixed issue of adding analytics impression pixel via Prebid's vastTrackers.js module.Getting object Required Array<string>. * Add test --------- Co-authored-by: shubham.si <[email protected]> Co-authored-by: Demetrio Girardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Issue
The issue arises when bid response has
vastUrl
as video response. Impression urls for analytics are registered via vastTrackers.registerVastTrackers function. This module gets impression urls on bidResponse and concatenate tobidResponse.vastImpUrl
asSet<Array<string>>
.The videoCache.js module then add these impression urls to vast. It requires impression urls as string|string[].
The current implementation for generating CDATA blocks in
<Impression>
tags is incorrectly handling impression trackers when the video response is a vastUrl. Instead of embedding the actual URLs, the output is showing[object Set]
.Code Ref. :
The code is meant to generate impression URLs by mapping over
impTrackerURLs
, which it assume isArray<string>
. However, instead of producing URLs as expected, the output inside the tags is[object Set]
when it should be the actual URLs as strings.This issue will impact video ad tracking, leading to incorrect reporting and analytics.
Steps to reproduce
Register vastTrackers function as mentioned here with any analytics adapter eg.,
medianetAnalytics
It can be a single url of type
event: impressions
event: impressions
Solution
Convert the
Set<string>
to an array before concatenating tobidResponse.vastImpUrl
.With videoResponse as vastUrl
With videoResponse as vastXml