IdentityLinkIdSystem: fix identity link throwing unhandled promises #12249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This pull request references the issue that was opened here
Essentially this callback here never gets executed when either of one of those 2 conditions inside this if is false.
In this case probably the identity link will return an empty value and we should see a message like this:
But instead we are seeing something like this:
While this pull request here is addressing the error of unhandling the promise, it won't address the fact that we should see in this case a message from prebid saying that it did return with an empty value, and that's what this PR is addressing.
Other information