-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symitri RTD module: OnBidResponse method added #12214
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0aa6664
OnBidResponse listener added to add pixel for deals matching to the u…
724c232
Adding support for simpleId, compositeId & hashedId
4ec8858
Solved Linter errors. Made some changes to reduce integration errors
bbf9ce2
Rolled back the default case as it was generating test errors.
544300c
Testing onBidResponseEvent
bb472a8
Pass pixel URL as module config parameter
d6351a7
Added extra attributes to Pixel URL.
fc28060
Bidder Name & Code both added
f559563
Fixed Tests
986ebcc
Merge pull request #3 from symitri-com/append-pixel-to-bid-response
jpalladino84 7dfb1a4
Merge branch 'prebid:master' into master
mp4symitri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,7 +78,8 @@ | |
apiVersion: "x1", | ||
domain: "prebid.org", | ||
identityValue: "[email protected]", | ||
identityType: "hid" | ||
identityType: "simpleid", | ||
pixelUrl: 'https://www.test.com/pixel' | ||
} | ||
} | ||
] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,11 +45,12 @@ pbjs.setConfig({ | |
apiVersion: "x1", | ||
apiAuthToken: '<see your Symitri account rep>', | ||
domain: 'your-domain.com', | ||
identityType: 'hid'| ... | 'dap-signature:1.0.0', | ||
identityType: 'simpleid'|'compositeid'|'hashedid'|'dap-signature:1.0.0', | ||
identityValue: '<user hid>', | ||
segtax: 501, | ||
dapEntropyUrl: 'https://sym-dist.symitri.net/dapentropy.js', | ||
dapEntropyTimeout: 1500 | ||
dapEntropyTimeout: 1500, | ||
pixelUrl: '<see your Symitri account rep>', | ||
} | ||
} | ||
] | ||
|
@@ -70,11 +71,19 @@ Please reach out to your Symitri account representative(<[email protected]>) to | |
| apiVersion | String | This holds the API version | It should be "x1" always | | ||
| apiAuthToken | String | Symitri API AuthToken | Please reach out to your Symitri account representative(<[email protected]>) for this value | | ||
| domain | String | The domain name of your webpage | | | ||
| identityType | String | Something like this 'hid', ... 'dap-signature:1.0.0' | | | ||
| identityType | String | 'simpleid' or 'compositeid' or 'hashedid' or 'dap-signature:1.0.0' | Use 'simpleid' to pass email or other plain text ids and SymitriRTD Module will hash it. | ||
Use 'hashedid' to pass in single already hashed id. Use 'compositeid' to pass in multiple identifiers as key-value pairs as shown below: | ||
{ | ||
"identityType1": "identityValue1", | ||
"identityType2": "identityValue2", | ||
... | ||
} | ||
| | ||
| identityValue | String | This is optional field to pass user hid. Will be used only if identityType is hid | | | ||
| segtax | Integer | The taxonomy for Symitri | The value should be 501 | | ||
| dapEntropyUrl | String | URL to dap entropy script | Optional if the script is directly included on the webpage. Contact your Symitri account rep for more details | | ||
| dapEntropyTimeout | Integer | Maximum time allotted for the entropy calculation to happen | | | ||
| pixelUrl | String | Pixel URL provided by Symitri which will be triggered when bid matching with Symitri dealid wins and creative gets rendered | | | ||
|
||
### Testing | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may want to also check for deals that match a particular pattern