Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharethrough Bid Adapter: update logic for isBidRequestValid #12136

Merged
merged 16 commits into from
Aug 19, 2024
Merged

Sharethrough Bid Adapter: update logic for isBidRequestValid #12136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1659209
Merge pull request #1586 from prebid/master
jefftmahoney Jan 9, 2024
a49852a
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney Jan 19, 2024
bc2e207
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney Feb 2, 2024
25e0e24
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney Mar 19, 2024
c5495ba
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney May 9, 2024
18c8328
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney May 20, 2024
7ce2843
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney Jun 17, 2024
63f6967
Merge pull request #1612 from prebid/master
jefftmahoney Jun 27, 2024
ca6a30b
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney Jun 27, 2024
b8d37a9
Merge pull request #1613 from prebid/master
jefftmahoney Jul 15, 2024
84da627
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney Jul 15, 2024
fade8b9
Merge pull request #1614 from prebid/master
jefftmahoney Jul 18, 2024
ef82a8b
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney Jul 18, 2024
7a2efee
Merge pull request #1615 from prebid/master
jefftmahoney Aug 18, 2024
198faf2
Merge branch 'master' of https://github.com/sharethrough/Prebid.js-in…
jefftmahoney Aug 18, 2024
178d5cb
Updating isBidRequestValid logic to account for aliasing of bidder names
jefftmahoney Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/sharethroughBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const sharethroughAdapterSpec = {
code: BIDDER_CODE,
supportedMediaTypes: [VIDEO, BANNER],
gvlid: 80,
isBidRequestValid: (bid) => !!bid.params.pkey && bid.bidder === BIDDER_CODE,
isBidRequestValid: (bid) => !!bid.params.pkey,

buildRequests: (bidRequests, bidderRequest) => {
const timeout = bidderRequest.timeout;
Expand Down
11 changes: 0 additions & 11 deletions test/spec/modules/sharethroughBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,8 @@ describe('sharethrough adapter spec', function () {
expect(spec.isBidRequestValid(invalidBidRequest)).to.eql(false);
});

it('should return false if req has wrong bidder code', function () {
const invalidBidRequest = {
bidder: 'notSharethrough',
params: {
pkey: 'abc123',
},
};
expect(spec.isBidRequestValid(invalidBidRequest)).to.eql(false);
});

it('should return true if req is correct', function () {
const validBidRequest = {
bidder: 'sharethrough',
params: {
pkey: 'abc123',
},
Expand Down