GumGum Bid Adapter : add ORTB2 device data to request payload #12008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/gumgumBidAdapter.js
|
@MartinGumGum - this PR will ensure GumGum benefits from publishers efficiently populating the device object with enriched data including iPhone model categories and other features not obtainable via SUA and UA. As publishers progress rollout this becomes more critical. |
patmmccann
reviewed
Oct 9, 2024
|
@BohdanVV Circleci build has failed could you please rerun and merge? |
|
Hi @MartinGumGum, I don't have the necessary permissions to do that, but I'll make sure to ask someone who does. :) |
|
Hi @patmmccann , maybe you can help us rerun circlei? We don't have permission. |
MartinGumGum
approved these changes
Oct 9, 2024
ChrisHuie
approved these changes
Oct 10, 2024
ChrisHuie
changed the title
pdamoc
pushed a commit
to missena-corp/Prebid.js
that referenced
this pull request
Oct 22, 2024
…#12008) * GumGum Bid Adapter: Add ORTB2 device data to request payload * GumGum Bid Adapter: add `ip` and `ipv6` to request payload --------- Co-authored-by: Bohdan V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR enhances the GumGum bid request by incorporating device data from the global ORTB2 object.
The device object has previously been populated by simplistic parsers, if at all, and was inaccurate as a result. Prebid now benefits from RTD modules such as 51Degrees that enrich all the device object fields including Apple iPhone model category and device ID. The PR enables GumGum’s users to benefit from device object improvements.
ORTB2 values have been mapped on to gumgum bid request parameter schema as follows:
Other information
cc: @MartinGumGum