videoHeroesAdapter: support eids #11974
Conversation
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Hi, it appears your adapter and the brave adapter are duplicates submitted by the same person. https://github.com/prebid/Prebid.js/commits?author=thebraveio Please solve before working in either one further, as with the addition of libraries to the project, we're now trying to eliminate large blocks of duplicated code |
|
Hi guys ! Ok we will change code to avoid duplicates, its different companies, but started by same team and code |
|
Tread carefully! This PR adds 53 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 44 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 43 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 12 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
modules/videoheroesBidAdapter.js
Outdated
|
|
||
| return { id: br.transactionId, w: size[0], h: size[1] }; | ||
| }; | ||
| return deviceObj; |
There was a problem hiding this comment.
why not just take the device object core has prepared for you on bidderRequest.ortb2.device? eg https://github.com/prebid/Prebid.js/pull/12053/files
There was a problem hiding this comment.
never used it before on any prebid connectors, interesting, so if it can replace all device regular data, lets update it
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
seems like bidderRequest.ortb2 not stable and guarantee to be available, but i do not include old device prepare for else cases - bidderRequest.ortb2?.device || {} |
|
I do not why, but there on test browser causing random errors after building |
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Still different strange errors after added ortb2 |
|
|
I will develop Native req / res convertor on another way, as you do not like when am using object to convert it and found there duplicate way (but i found a lot of adapters with same ways also with absolutely same object like I did ), which is still the best variant I guess |
|
Has been updated as you asked for, now native full from scratched - without using convert object and without used old one parts, can not say I like this change, but its another way to explain logic compatible with our exchange systems and old clients |
…rebuild as it tests errors not depend on code)
…rebuild as trere test errors not depend on code)
|
About commits with changing line - I made it to rebuild projects, as there all time errors not about adapter, more situate like some adapters servers results, etc
|
…rebuild as trere test errors not depend on code)
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Added support of eids array to provide our exchange servers with user data from user submodules