viantOrtbBidAdapter': deals support

[skapoor-viant]

Type of change

• Feature

Description of change

Added pmp deals json in final request created by viantOrtbBidAdapter.

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[patmmccann]

This is very interesting, please also support the standard location on the imp object though

[skapoor-viant]

This is very interesting, please also support the standard location on the imp object though

@patmmccann I fixed the rest code changes from my side, but please let me know if there's something from my side I would need to do for duplicated code check?

[patmmccann]

Duplicated code very minor, safe to ignore or fix if you like and prefer to not have the warning, I marked draft because you didn't have any tests and you didn't support the standard location for the deals object on the ortb2Imp part of the request

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[patmmccann]

Adding some detail here, a publisher should be able to define a pmp like this https://docs.prebid.org/dev-docs/adunit-reference.html#first-party-data ; not just via your adapter parameters. It is a requirement you support the standard openrtb way of forming a bid request when you provide a parameter. The most frequent publisher complaint about prebid is bidder parameters having redundant implementations of the same information

   code: "test-div",
   mediaTypes: {
       banner: {
           sizes: [[300,250]]
       }
   },
   ortb2Imp: {
            "pmp": {
               "private_auction": 0,
               "deals": [
                   {
                       "id": "5678",
                       "bidfloor": 1.75,
                       "bidfloorcur": "USD",
                       "wseat": [
                           "16"
                       ],
                       "at": 3
                   },
                   {
                       "id": "1234",
                       "bidfloor": 2,
                       "bidfloorcur": "USD",
                       "wseat": [
                           "3539"
                       ],
                       "at": 1
                   },
               .....
   // ...
});`````

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[skapoor-viant]

Adding some detail here, a publisher should be able to define a pmp like this https://docs.prebid.org/dev-docs/adunit-reference.html#first-party-data ; not just via your adapter parameters. It is a requirement you support the standard openrtb way of forming a bid request when you provide a parameter. The most frequent publisher complaint about prebid is bidder parameters having redundant implementations of the same information

   code: "test-div",
   mediaTypes: {
       banner: {
           sizes: [[300,250]]
       }
   },
   ortb2Imp: {
            "pmp": {
               "private_auction": 0,
               "deals": [
                   {
                       "id": "5678",
                       "bidfloor": 1.75,
                       "bidfloorcur": "USD",
                       "wseat": [
                           "16"
                       ],
                       "at": 3
                   },
                   {
                       "id": "1234",
                       "bidfloor": 2,
                       "bidfloorcur": "USD",
                       "wseat": [
                           "3539"
                       ],
                       "at": 1
                   },
               .....
   // ...
});`````

@patmmccann I am doing the changes based on your comment, but I do see the same json which I used is also being used by pubmatic adapter. Please check the link: pubmatic
Is prebid enforcing this change for all the adapters to standardize the adUnits?

[skapoor-viant]

@patmmccann I have made the changes and added test case for that. Please review it.

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/trafficgateBidAdapter.js has 6 duplicated lines with modules/viantOrtbBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[skapoor-viant]

@patmmccann Could you please review it again at your earliest convenience? It is currently a blocker for our team and needs to be merged as soon as possible.

[patmmccann]

@pm-harshad-mane @jlquaccia @pm-manasi-moghe please see discussion above

[patmmccann]

@skapoorviant looks great! Please document