Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libraries: New utility file to Remove code duplication in several adapters #11854

Merged
merged 7 commits into from
Jun 22, 2024
Merged

Libraries: New utility file to Remove code duplication in several adapters #11854

merged 7 commits into from
Jun 22, 2024

Conversation

MaksymTeqBlaze
Copy link
Contributor

@MaksymTeqBlaze MaksymTeqBlaze commented Jun 21, 2024 •
edited
Loading

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Created a library and utilized its functions in several adapters

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@MaksymTeqBlaze MaksymTeqBlaze marked this pull request as draft June 21, 2024 14:01
@patmmccann
Copy link
Collaborator

patmmccann commented Jun 22, 2024 •
edited
Loading

You're my hero, thank you. This was clearly no small undertaking.

@patmmccann patmmccann self-assigned this Jun 22, 2024
@patmmccann
Copy link
Collaborator

@MaksymTeqBlaze why still in draft? I would love to merge the work you've accomplished so far

@patmmccann patmmccann changed the title Remove code duplication in several adapters Libraries: New utility file to Remove code duplication in several adapters Jun 22, 2024
@MaksymTeqBlaze
Copy link
Contributor Author

@MaksymTeqBlaze why still in draft? I would love to merge the work you've accomplished so far

@patmmccann there are still some adapters that have same code and i need to add one small improvement for isBidRequestValid function

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@MaksymTeqBlaze MaksymTeqBlaze marked this pull request as ready for review June 22, 2024 12:33
@MaksymTeqBlaze
Copy link
Contributor Author

@patmmccann I have updated all adapters that I saw had this duplicated code and did not have much custom code. I also provided some functions that allow building requests with custom fields and logic.

@patmmccann patmmccann merged commit 850e0e2 into prebid:master Jun 22, 2024
3 of 4 checks passed
This was referenced Jun 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jun 27, 2024
Merged
Open
@patmmccann patmmccann mentioned this pull request Jul 8, 2024
Merged
1 task
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
@MaksymTeqBlaze @DecayConstant
Libraries: New utility file to Remove code duplication in several ada…
d0fa6db 
…pters (prebid#11854)

* Added library

* updated bidderUtils and used it in some adapters

* added library functions to several new adapters

* added library functions to several new adapters

* added library functions to several new adapters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaksymTeqBlaze @patmmccann