Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMDS Bid Adapter : add support for video.plcmt #11615

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

tgcallaway
Copy link
Contributor

Type of change

  • Updated bidder adapter

Description of change

Add support for video.plcmt

@ChrisHuie
Copy link
Collaborator

@tgcallaway can you fix the newline issue at the end of your adapter file so it passes lint checks please?

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your linting error please

@tgcallaway
Copy link
Contributor Author

@patmmccann @ChrisHuie thank you, linting error resolved.

@tgcallaway tgcallaway requested a review from patmmccann May 30, 2024 21:05
@ChrisHuie ChrisHuie self-assigned this Jun 3, 2024
@ChrisHuie ChrisHuie changed the title IMDS Bid Adapter: support video.plcmt IMDS Bid Adapter : add support for video.plcmt Jun 3, 2024
@ChrisHuie ChrisHuie merged commit 4d1692e into prebid:master Jun 3, 2024
4 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* imds: Rename usersync from "pixel" to correct name of "image".

* imds: Update documentation for "DFP Video Creative" to match prebid.github.io.

* imds: Test modifications for renamed pixel->image usersync

* imds: Remove warning for valid no-bid empty body 204 responses.

* updates imds bidder for prebid9 with video.plcmt

* newline

---------

Co-authored-by: Timothy M. Ace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants