-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LiveIntent Identity Module: Introduce First Party ID #11437
Conversation
0e8affa
to
5224b3e
Compare
dec60e7
to
bf5debf
Compare
4e318e1
to
ee14798
Compare
this generally looks ok to me. @SKOCHERI can you confirm the changes to package-lock.json are acceptable? |
@SKOCHERI Can you please have a look at this PR? |
The package-lock and package file changes seem fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused . I thought the intent was to remove the dependency on a 3rd party which is currently not allowed by any module today. This PR updates the dependency to new version of that 3rd party module ?
* fpid * lint * Adjust tests * Fix test expectation * live-connect v6.7.3
* fpid * lint * Adjust tests * Fix test expectation * live-connect v6.7.3
Type of change
Description of change
LiveIntent user ID module will be able to expose first party identifiers as
fpid
. In the current stage,fpid
is read from either cookie jar or local storage depending in the configuration. In a future release, it can be populated from the LI user id module cookie.Configuration to enable
fpid
:Other information