Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics Fpd Module: Add vidazoo bidder iframe #11283

Merged
merged 2 commits into from
May 29, 2024

Conversation

saar120
Copy link
Contributor

@saar120 saar120 commented Apr 3, 2024

Type of change

  • Feature

Description of change

Added Vidazoo bidder to topicsFpdModule.

Other information

@saar120 saar120 changed the title Add vidazoo bidder to topicsFpdModule. Topics Fpd Module: Add vidazoo bidder iframe Apr 3, 2024
@saar120
Copy link
Contributor Author

saar120 commented Apr 15, 2024

@patmmccann @ChrisHuie
Can we merge this please?

@patmmccann
Copy link
Collaborator

we're still thinking about if we want to allow nonmember companies in a vendorless module

@bgoldin-vidazoo
Copy link

we're still thinking about if we want to allow nonmember companies in a vendorless module

Hi, nice to meet you! Hivestack are prebid members. Them and us are all part of the same company - Perion Network. Might this suffice to include us in the module as well?

@bgoldin-vidazoo
Copy link

@patmmccann Hi Patrick, sure you're busy but would be grateful for your help here. Can we merge this in light that we do have a membership through our sister business unit Hivestack?

@patmmccann
Copy link
Collaborator

We discussed in committee. We're going to remove everyone from the Topics module and require publishers configure each bidder in Prebid 9. Merging this for now but it will be removed shortly with everyone else

@patmmccann
Copy link
Collaborator

oh, needs conflicts resolved

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging for now, will remove with everyone else for prebid 9

@saar120
Copy link
Contributor Author

saar120 commented May 25, 2024

oh, needs conflicts resolved

@patmmccann resolved

@patmmccann patmmccann merged commit 38ca7c2 into prebid:master May 29, 2024
4 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants