-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAAPI: add support for protected audience extensions and "direct" buyers (igb
)
#11277
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1f272a2
set ortb2Imp.ext.igs
dgirardi 093ac4e
PAAPI: add ortbConverter support for request ext.igi and response ext…
dgirardi 7b981b8
Merge branch 'master' into paapi-igb
dgirardi 259b77c
Merge branch 'master' into paapi-igb
dgirardi 0f4ed07
Update paapi hook to accept auction config as one field
dgirardi 9fd08ed
mergeBuyers
dgirardi f91c864
partitionBuyers
dgirardi 2ca5a83
Merge branch 'master' into paapi-extensions
dgirardi c1d238a
Merge branch 'master' into paapi-igb
dgirardi 482201b
add fpd to perBuyerSignals
dgirardi be3e1b3
complete igb treatment
dgirardi 66036ec
improve names
dgirardi e69c3a1
parse ext.igi.igb
dgirardi f68a9f3
Merge branch 'master' into paapi-igb
dgirardi f23cb5a
Merge branch 'paapi-igb' into paapi-extensions
dgirardi 0c211aa
naming improvement
dgirardi 31e61e7
update debugging mod to work with igb
dgirardi 4001b60
fix mergeBuyers to work with actual URL origins
dgirardi b375865
rename componentBuyers to componentSeller
dgirardi 67b7cc3
signal componentSeller config to bid adapters
dgirardi bea455f
Merge branch 'master' into paapi-extensions
dgirardi 13ad336
Merge branch 'master' into paapi-igb
dgirardi e7e32a8
Merge branch 'paapi-igb' into paapi-extensions
dgirardi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed on https://github.com/InteractiveAdvertisingBureau/openrtb/blob/main/extensions/community_extensions/Protected%20Audience%20Support.md, it states that the biddable field is 0 by default (indicating a buyer is not allowed). Also saw in the prebid "fledge" slack channel (about a month back) that the biddable field default may get reversed to 1 instead. Is there an update on the latest around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK there's no concrete plan for the spec to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this default in the spec a strange choice as well, however, Prebid can default to a different value than a dsp should interpret a result with a missing value. A dsp should consider biddable null as non-biddable, we'll always pass 1, bc we consider these requests worthwhile. What a dsp should consider biddable null to mean doesn't impact what field we should choose to pass.