Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery Bid Adapter : Extend the expiration time of pmguid #11154

Merged
merged 13 commits into from
Mar 11, 2024
Merged

Discovery Bid Adapter : Extend the expiration time of pmguid #11154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c3eb0a8
Discovery Bid Adapter : add title, desc, keywords, hLen, nbw, hc, dm …
Jan 5, 2024
cb251c0
Discovery Bid Adapter : add title, desc, keywords, hLen, nbw, hc, dm …
Jan 5, 2024
2a1d7c2
Merge branch 'prebid:master' into master
lhxx121 Jan 10, 2024
137dbbb
Discovery Bid Adapter : synchronize mguid from third party cookie to …
Jan 10, 2024
01ff272
test
Feb 21, 2024
67bd4f3
Merge branch 'prebid:master' into master
lhxx121 Feb 22, 2024
4fc76aa
Merge branch 'prebid:master' into master
lhxx121 Feb 29, 2024
96c9beb
Discovery Bid Adapter : Extend the expiration time of pmguid
Feb 29, 2024
635cd7c
Discovery Bid Adapter : Extend the expiration time of pmguid
Feb 29, 2024
bc598d5
Discovery Bid Adapter : Extend the expiration time of pmguid
Mar 4, 2024
f937a3e
Merge branch 'prebid:master' into master
lhxx121 Mar 4, 2024
2ed03db
Discovery Bid Adapter : Extend the expiration time of pmguid
Mar 4, 2024
21ce94a
Merge branch 'prebid:master' into master
lhxx121 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions modules/discoveryBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const NATIVERET = {
};

/**
* get page title
* get page title111
* @returns {string}
*/

Expand Down Expand Up @@ -133,10 +133,11 @@ export const getPmgUID = () => {
let pmgUid = storage.getCookie(COOKIE_KEY_PMGUID);
if (!pmgUid) {
pmgUid = utils.generateUUID();
try {
storage.setCookie(COOKIE_KEY_PMGUID, pmgUid, getCurrentTimeToUTCString());
} catch (e) {}
}
// Extend the expiration time of pmguid
try {
storage.setCookie(COOKIE_KEY_PMGUID, pmgUid, getCurrentTimeToUTCString());
} catch (e) {}
return pmgUid;
};

Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/discoveryBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ describe('discovery:BidAdapterTests', function () {
storage.getCookie.callsFake(() => 'existing-uuid');
const uid = getPmgUID();
expect(uid).to.equal('existing-uuid');
expect(storage.setCookie.called).to.be.false;
expect(storage.setCookie.called).to.be.true;
});

it('should not set new UUID when cookies are not enabled', () => {
Expand Down