User id module: adds a catch to greedy promise

[mmoschovas]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Errors that occur currently throw an Uncaught promise error on page. This adds a catch to avoid the error and logs as well for debugging

Other information

[dgirardi]

as discussed offline, I am not able to repro the issue so I am grasping at straws here - instead of this, could you try replacing

    if (cancel != null) {
      cancel.reject(INIT_CANCELED);
    }

with

    ((c) => {
      setTimeout(() => {
        if (c != null) {
          c.reject(INIT_CANCELED);
        }
      })
    })(cancel);

and see if it makes any difference? (this change also fails tests but I think that's a problem with the tests so if it works I can go ahead and look at them as well).

[patmmccann]

Doesnt appear that worked, if we change from logWarn to logError is that more palatable?

[patmmccann]

it seems

Prebid.js/modules/userId/index.js

Line 706 in d53dae2

function refreshUserIds({submoduleNames} = {}, callback) {

may trigger the cancel

[coreyb-cbs]

@dgirardi @patmmccann Not sure if it's helpful, but I experienced this uncaught promise error when calling refreshUserIds twice in quick succession. I was able to eliminate the error by removing one of those calls (it wasn't necessary anymore). It was on my to-do list to raise this up in a Git issue to have the promise fail more gracefully or provide some sort of error context. I was able to reproduce consistently in Chrome. I can probably dig up an old bundle if that's helpful, let me know.

I am able to reproduce on every page load:

1. set up a network request redirect from https://at.cbsi.com/lib/dist/prod/bidbarrel-maxpreps.min.js to https://at.cbsi.com/lib/dist/v3.19.0/all/bidbarrel-maxpreps.js
2. visit https://www.maxpreps.com
3. check local storage fmscw_resp for value.fms_params.fms_UID2
4. if it doesn't exist then you need to log in with an account
5. once that fms_UID2 object exists, check the console error logs for Uncaught (in promise) {}

[dgirardi]

@coreyb-cbs could you verify if the issue still happens after #12246?