ZetaGlobalSsp Analytics Adapter : make event object with only needed fields #10555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull master
11111111111# the commit.
robertrmartinez
requested changes
Oct 10, 2023
ChrisHuie
changed the title
|
Please add a couple unit tests regarding this update. |
|
@robertrmartinez done |
robertrmartinez
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Due to the complex object (args.doc) with cyclic dependence of fields, we had a bug associated with the impossibility of turning this object into a json. Therefore, we are forced to make logic that will leave only the fields we need in the object.
Please note that JSON.stringify(args) may produce an exception because of that.