Support for downloading Analytics Adapters via http://prebid.org/download.html #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change
ET-1850: Fixing #866
anand-venkatraman
changed the title
9 tasks
|
can you modify this so that you can pass in a path to the file, the same way you can for standard adapters? Thanks! |
mkendall07
reviewed
Mar 9, 2017
analytics.json
Outdated
| "ga", | ||
| "pulsepoint", | ||
| "roxot", | ||
| "sharethrough_analytics" |
There was a problem hiding this comment.
let's remove these as this will change the default behavior of building with all the analytics adapters.
There was a problem hiding this comment.
Removed all the analytics adapter entries in the file. Though I think, it is probably a good idea to bundle all of them in the default build.
|
yeah this is fine with me. |
snapwich
approved these changes
Mar 30, 2017
|
LGTM. |
|
Docs are outdated on building from local checkout repo. Plus there are no tests covering the usage of analytics.json in the build as far as I can tell |
|
New syntax is With an array defined in analytics.json |
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 19, 2017
…19.0 to aolgithub-master * commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits) Disable unit tests that fails on PhantomJs. Fixed unit tests for adapter loader. Changed way of including analytic adapters. Added adapters in aolPartnersIds.json. Added changelog entry. Replace removed utils.extend functionality by object.assign. Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) Updated rubicon video bid endpoint in source and test files (prebid#1097) Pass through params to server (prebid#1084) Reset the list of slots to be requested between each action for pubmatic (prebid#1079) Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021) update PR template to include link to dev docs page (prebid#1075) Prebid 0.21.0 Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054) Video header bidding support to RhythmOne bidder adapter (prebid#1052) Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045) Fix adapter getSize (prebid#1064) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
In order to be able to build prebid.js from the Downloads page, this change would help specifying analytics adapters to include in the bundle. This change was requested as part of prebid/prebid.github.io#132