Oxxion Analytics Adapter: fix video bid stringify #10119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
didnt you just submit this pr? Do you have two adapters? |
|
Yes, I've tried to rename it last year but I was told it would be better to create a second one to avoid breaking changes. |
patmmccann
approved these changes
Jun 22, 2023
musikele
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
JSON.stringify on bid response does not work when the object has a renderer attribute because of circular references. As I didn't find a proper way to make a clean dereferenced copy of the object, I've choose to save the render value in a temporary variable, remove it for the bid, stringify the bid and the push back the renderer inside. Not proud of it, but it would have been easier if analytics module could have received already dereferenced object so we can manipulate them without messing out with other parts of prebid.js