New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug in 1.0 with `hb_deal` being replaced with `hb_deal_bidder` #3059

Closed

snapwich opened this issue Sep 6, 2018 · 0 comments · Fixed by #3062

Assignees

Collaborator

snapwich commented Sep 6, 2018

Type of issue

possible bug

Description

In the 1.0 update there were changes to targeting reflecting issues with hb_deal in #1574. In this comment the idea of adding hb_deal_{bidder_code} to the the standard keys was discussed and then implemented here. However, the code update replaces hb_deal with hb_deal_{bidder_code} meaning that hb_deal is never sent, only hb_deal_{bidder_code}.

I'm not positive that this change was intentional. If it was, it should be reflected in the 1.0 Publisher API changes documented here. If it was not, then it's a bug that needs to be fixed.

Steps to reproduce

Return a dealId as a bidder in 1.0. hb_deal_{bidder_code} will be sent as targeting data but hb_deal will not.

The text was updated successfully, but these errors were encountered:

snapwich assigned jaiminpanchal27 and mkendall07

ZLester added a commit to ZLester/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

09032b7

ZLester added a commit to ZLester/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

ebe25fb

ZLester mentioned this issue

Fix #3059 by returning both hb_deal and hb_deal_${bidder_code} #3062

Merged

1 task

harpere closed this as completed in #3062

harpere pushed a commit that referenced this issue


          Fix #3059 by returning both hb_deal and hb_deal_${bidder_code} (#3062)

ebfbc54

* Fix #3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07

ptomasroos pushed a commit to happypancake/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} (p…

8c36005

…rebid#3062)

* Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07

StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} (p…

930f232

…rebid#3062)

* Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07

SublimeJeremy pushed a commit to SublimeSkinz/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} (p…

c08d730

…rebid#3062)

* Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07

ghost pushed a commit to devunrulymedia/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} (p…

0bfa5f9

…rebid#3062)

* Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07

pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} (p…

8ff433c

…rebid#3062)

* Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} (p…

1a7f520

…rebid#3062)

* Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this issue


          Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code} (p…

9cbd0b4

…rebid#3062)

* Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment