Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace for pbjs #115

Closed
cwbeck opened this issue Nov 24, 2015 · 6 comments
Closed

Namespace for pbjs #115

cwbeck opened this issue Nov 24, 2015 · 6 comments
Assignees
Labels

Comments

@cwbeck
Copy link

cwbeck commented Nov 24, 2015

Hi,

Is there any plan to eventually namespace this project? While it will not be an issue for publishers, it could impact networks trying to use it and distribute it as it might conflict with some publisher's sites.

It would be nice to specify a top-level namespace other than pbjs pre-build.

Thanks,

Chris

@mkendall07
Copy link
Member

Hi @cwbeck,

Do you mean another alias that is longer? pbjs is the global namespace as of now.

@cwbeck
Copy link
Author

cwbeck commented Nov 25, 2015

Hi @mkendall07

Correct, pbjs is the global namespace, but would it be possible to set this as a variable in the build so we could for example have abcd instead? This would prevent any conflicts whereby pbjs was already in use by someone else.

@baragona
Copy link
Contributor

I agree, this would be very helpful!

@baragona
Copy link
Contributor

Maybe it would be helpful if prebid.js could be require'd like a library from other code, and that when used this way, the global variable would have a randomized name to prevent conflicts from other usages?

@Heray
Copy link

Heray commented Mar 28, 2016

Assigning back to @protonate - as soon as the commit was closed.

@mkendall07
Copy link
Member

merged

pixfuture-media added a commit to pixfuture-media/Prebid.js that referenced this issue Aug 9, 2021
Changed directory path in the line prebid#115  from url: `${hostname}/auc/auc.php` to ${hostname}/
ChrisHuie pushed a commit that referenced this issue Aug 9, 2021
Changed directory path in the line #115  from url: `${hostname}/auc/auc.php` to ${hostname}/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants