Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhythmone: Multiple requestBids Not Working #1123

Closed
CarsonBanov opened this issue Apr 12, 2017 · 1 comment
Closed

Rhythmone: Multiple requestBids Not Working #1123

CarsonBanov opened this issue Apr 12, 2017 · 1 comment

Comments

@CarsonBanov
Copy link
Contributor

Type of issue

Bug

Description

Similar issue to this one. Upon making a second request to pbjs.requestBids the Rhythmone adapter never returns a bid causing the Prebid auction to hit the timeout.

Steps to reproduce

Define two ad units. Run requestBids twice - once the first ad unit and a separate one on the second. Then run pbjs.getBidResponses() or log the bids in some other way. Rhythmone won't bid or even return an empty bid.

Expected results

Actual results

Platform details

Other information

.cc @ehoch @mkendall07 @protonate

matthewlane pushed a commit that referenced this issue May 2, 2017
…#1134)

* added audit beacon to detect misuse of this bidder.  Detects auctions within iframes or popup windows.

* fix for bug #1123 - Rhythmone: Multiple requestBids Not Working.  An auction ended flag was set, preventing additional auctions from completing.  This has been removed along with some google analytics tracking code.

* Altered the beacon logging domain to something with a functional SSL cert.

* updating s3 bucket name

* updating s3 bucket name _again_.

* Adding optional curly braces.  Removing optional parentheses.
@mkendall07
Copy link
Member

Looks like this fix is in master.

dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
…prebid#1134)

* added audit beacon to detect misuse of this bidder.  Detects auctions within iframes or popup windows.

* fix for bug prebid#1123 - Rhythmone: Multiple requestBids Not Working.  An auction ended flag was set, preventing additional auctions from completing.  This has been removed along with some google analytics tracking code.

* Altered the beacon logging domain to something with a functional SSL cert.

* updating s3 bucket name

* updating s3 bucket name _again_.

* Adding optional curly braces.  Removing optional parentheses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants