Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with SpringServe adapter. #1100

Closed
adilets opened this issue Apr 4, 2017 · 1 comment
Closed

Problem with SpringServe adapter. #1100

adilets opened this issue Apr 4, 2017 · 1 comment

Comments

@adilets
Copy link
Contributor

adilets commented Apr 4, 2017 •
edited
Loading

I get this response from bidder.springserve.com:

pbjs.handleSpringServeCB({"nbr":0,"id":"1","seatbid":[{"seat":"YH","bid":[{"ext":null,"id":"7777-333-444_1","impid":"7777-333-444","crid":null,"price":0.64083135,"adm":"DEBUG BID CONTENT","dealid":""}]}],"cur":"USD"})

https://github.com/prebid/Prebid.js/blob/master/src/adapters/springserve.js#L73
has this check: bid.params.impId === +responseBid.impid
response from springserve has responseBid.impid = "7777-333-444". Which becomes NaN because of preceding +
adilets added a commit to adilets/Prebid.js that referenced this issue Apr 4, 2017
@adilets
Fixes SpringServe adapter
aeaa384 
Fixes - prebid#1100
@adilets adilets mentioned this issue Apr 4, 2017
Merged
9 tasks
mkendall07 pushed a commit that referenced this issue Apr 17, 2017
@adilets
Fixes SpringServe adapter (#1101)
6e49594 
Fixes - #1100
@matthewlane
Copy link
Collaborator

Closing with #1101 merged

dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
@adilets @dluxemburg
Fixes SpringServe adapter (prebid#1101)
56900a8 
Fixes - prebid#1100
This was referenced Aug 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewlane @adilets