Check sendId parameter for native ads and warn if missing on required…

… assets
prebid · Apr 8, 2020 · f568d4c · f568d4c
1 parent de504a9
commit f568d4c
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/modules/criteoBidAdapter.js b/modules/criteoBidAdapter.js
@@ -9,13 +9,14 @@ import { verify } from 'criteo-direct-rsa-validate/build/verify.js';
 import { getStorageManager } from '../src/storageManager.js';
 
 const GVLID = 91;
-export const ADAPTER_VERSION = 27;
+export const ADAPTER_VERSION = 28;
 const BIDDER_CODE = 'criteo';
 const CDB_ENDPOINT = 'https://bidder.criteo.com/cdb';
 const CRITEO_VENDOR_ID = 91;
 const PROFILE_ID_INLINE = 207;
 export const PROFILE_ID_PUBLISHERTAG = 185;
 const storage = getStorageManager(GVLID);
+const LOG_PREFIX = 'Criteo: ';
 
 // Unminified source code can be found in: https://github.com/Prebid-org/prebid-js-external-js-criteo/blob/master/dist/prod.js
 const PUBLISHER_TAG_URL = 'https://static.criteo.net/js/ld/publishertag.prebid.js';
@@ -253,6 +254,7 @@ function buildCdbUrl(context) {
  */
 function buildCdbRequest(context, bidRequests, bidderRequest) {
   let networkId;
+  let hasNativeSendId = true;
   const request = {
     publisher: {
       url: context.url,
@@ -280,6 +282,16 @@ function buildCdbRequest(context, bidRequests, bidderRequest) {
       }
       if (bidRequest.params.nativeCallback || utils.deepAccess(bidRequest, `mediaTypes.${NATIVE}`)) {
         slot.native = true;
+        if (bidRequest.nativeParams &&
+          ((bidRequest.nativeParams.image && bidRequest.nativeParams.image.sendId !== true) ||
+            (bidRequest.nativeParams.icon && bidRequest.nativeParams.icon.sendId !== true) ||
+            (bidRequest.nativeParams.clickUrl && bidRequest.nativeParams.clickUrl.sendId !== true) ||
+            (bidRequest.nativeParams.displayUrl && bidRequest.nativeParams.displayUrl.sendId !== true) ||
+            (bidRequest.nativeParams.privacyLink && bidRequest.nativeParams.privacyLink.sendId !== true) ||
+            (bidRequest.nativeParams.privacyIcon && bidRequest.nativeParams.privacyIcon.sendId !== true))
+        ) {
+          hasNativeSendId = false;
+        }
       }
       if (hasVideoMediaType(bidRequest)) {
         const video = {
@@ -288,7 +300,7 @@ function buildCdbRequest(context, bidRequests, bidderRequest) {
           protocols: bidRequest.mediaTypes.video.protocols,
           maxduration: bidRequest.mediaTypes.video.maxduration,
           api: bidRequest.mediaTypes.video.api
-        }
+        };
 
         video.skip = bidRequest.params.video.skip;
         video.placement = bidRequest.params.video.placement;
@@ -301,6 +313,9 @@ function buildCdbRequest(context, bidRequests, bidderRequest) {
       return slot;
     }),
   };
+  if (!hasNativeSendId) {
+    utils.logWarn(LOG_PREFIX + 'all native assets containing URL should be sent as placeholders with sendId(icon, image, clickUrl, privacyLink, privacyIcon)');
+  }
   if (networkId) {
     request.publisher.networkid = networkId;
   }