Skip to content

Commit

Permalink
Update dfpAdServerVideo.js to allow for vast4 (#5608)
Browse files Browse the repository at this point in the history
* Update dfpAdServerVideo.js

This had a bug in which all requests were hardcoded to vast 3, although pubs may have selected vast 3 or 4

* Update dfpAdServerVideo_spec.js

* Update dfpAdServerVideo_spec.js
  • Loading branch information
patmmccann authored Aug 20, 2020
1 parent 23af840 commit f0e4433
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion modules/dfpAdServerVideo.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import { auctionManager } from '../src/auctionManager.js';
const defaultParamConstants = {
env: 'vp',
gdfp_req: 1,
output: 'xml_vast3',
output: 'vast',
unviewed_position_start: 1,
};

Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/dfpAdServerVideo_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('The DFP video support module', function () {
expect(queryParams).to.have.property('env', 'vp');
expect(queryParams).to.have.property('gdfp_req', '1');
expect(queryParams).to.have.property('iu', 'my/adUnit');
expect(queryParams).to.have.property('output', 'xml_vast3');
expect(queryParams).to.have.property('output', 'vast');
expect(queryParams).to.have.property('sz', '640x480');
expect(queryParams).to.have.property('unviewed_position_start', '1');
expect(queryParams).to.have.property('url');
Expand Down Expand Up @@ -375,7 +375,7 @@ describe('The DFP video support module', function () {
expect(queryParams).to.have.property('env', 'vp');
expect(queryParams).to.have.property('gdfp_req', '1');
expect(queryParams).to.have.property('iu', 'my/adUnit');
expect(queryParams).to.have.property('output', 'xml_vast3');
expect(queryParams).to.have.property('output', 'vast');
expect(queryParams).to.have.property('sz', '640x480');
expect(queryParams).to.have.property('unviewed_position_start', '1');
expect(queryParams).to.have.property('url');
Expand Down

0 comments on commit f0e4433

Please sign in to comment.