Skip to content

Commit

Permalink
rubicon: removing maxduration as a required bidder parameter (#6513)
Browse files Browse the repository at this point in the history
  • Loading branch information
bretg authored Apr 1, 2021
1 parent 5ffe2c1 commit 84f70ff
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion modules/rubiconBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -1108,7 +1108,6 @@ export function hasValidVideoParams(bid) {
var requiredParams = {
mimes: arrayType,
protocols: arrayType,
maxduration: numberType,
linearity: numberType,
api: arrayType
}
Expand Down
10 changes: 0 additions & 10 deletions test/spec/modules/rubiconBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1821,16 +1821,6 @@ describe('the rubicon adapter', function () {
delete bidderRequest.bids[0].mediaTypes.video.protocols;
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);

// change maxduration to an string, no good
createVideoBidderRequest();
bidderRequest.bids[0].mediaTypes.video.maxduration = 'string';
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);

// delete maxduration, no good
createVideoBidderRequest();
delete bidderRequest.bids[0].mediaTypes.video.maxduration;
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);

// change linearity to an string, no good
createVideoBidderRequest();
bidderRequest.bids[0].mediaTypes.video.linearity = 'string';
Expand Down

0 comments on commit 84f70ff

Please sign in to comment.