Skip to content

Commit

Permalink
Prebid 8: use prebid.floors.floorMin instead of prebid.floorMin (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
dgirardi authored May 22, 2023
1 parent 86346eb commit 78d495b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions modules/priceFloors.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,9 @@ export function getFirstMatchingFloor(floorData, bidObject, responseObject = {})
matchingRule
};
// use adUnit floorMin as priority!
if (typeof deepAccess(bidObject, 'ortb2Imp.ext.prebid.floorMin') === 'number') {
matchingData.floorMin = bidObject.ortb2Imp.ext.prebid.floorMin;
const floorMin = deepAccess(bidObject, 'ortb2Imp.ext.prebid.floors.floorMin');
if (typeof floorMin === 'number') {
matchingData.floorMin = floorMin;
}
matchingData.matchingFloor = Math.max(matchingData.floorMin, matchingData.floorRuleValue);
// save for later lookup if needed
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/priceFloors_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ describe('the price floors module', function () {
let myBidRequest = { ...basicBidRequest };

// should take adunit floormin first even if lower
utils.deepSetValue(myBidRequest, 'ortb2Imp.ext.prebid.floorMin', 2.2);
utils.deepSetValue(myBidRequest, 'ortb2Imp.ext.prebid.floors.floorMin', 2.2);
expect(getFirstMatchingFloor(inputFloorData, myBidRequest, { mediaType: 'banner', size: '*' })).to.deep.equal({
floorMin: 2.2,
floorRuleValue: 1.0,
Expand All @@ -297,7 +297,7 @@ describe('the price floors module', function () {
delete inputFloorData.matchingInputs;

// should take adunit floormin if higher
utils.deepSetValue(myBidRequest, 'ortb2Imp.ext.prebid.floorMin', 3.0);
utils.deepSetValue(myBidRequest, 'ortb2Imp.ext.prebid.floors.floorMin', 3.0);
expect(getFirstMatchingFloor(inputFloorData, myBidRequest, { mediaType: 'banner', size: '*' })).to.deep.equal({
floorMin: 3.0,
floorRuleValue: 1.0,
Expand Down

0 comments on commit 78d495b

Please sign in to comment.