Single text node hot path #4523
Open
+117
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
JoviDeCroock
force-pushed
the
revive-3939
branch
from
cd0f32b
to
f5156c4
Compare
|
Size Change: +420 B (+0.68%) Total Size: 62.5 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
revive-3939
branch
from
f5156c4
to
428ac57
Compare
Thompson1985
approved these changes
Oct 6, 2024
Thompson1985
approved these changes
Oct 6, 2024
JoviDeCroock
force-pushed
the
revive-3939
branch
2 times, most recently
from
20e7020
to
91f6188
Compare
JoviDeCroock
requested review from
developit,
marvinhagemeister and
rschristian
rschristian
approved these changes
Oct 12, 2024
rschristian
reviewed
Oct 12, 2024
JoviDeCroock
force-pushed
the
revive-3939
branch
from
b4f7cfa
to
76a3098
Compare
|
Looking at the results, the warmup might close the gap a little on average, but not totally: https://github.com/preactjs/preact/actions/runs/11304050028/job/31441949188 Can probably revert/drop that, sorry. Was good to confirm I suppose though. |
JoviDeCroock
force-pushed
the
revive-3939
branch
4 times, most recently
from
e109c40
to
c664014
Compare
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
JoviDeCroock
force-pushed
the
revive-3939
branch
2 times, most recently
from
20942aa
to
021c18d
Compare
JoviDeCroock
force-pushed
the
revive-3939
branch
from
021c18d
to
3bf818a
Compare
marvinhagemeister
approved these changes
Oct 13, 2024
developit
reviewed
Oct 15, 2024
|
|
||
| newVNode._children = [ | ||
| // @ts-expect-error | ||
| createVNode(null, (dom.textContent = newChildren), null, null) |
There was a problem hiding this comment.
We might want to consider using dom.appendChild(document.createTextNode(newChildren)) and manually removing previous children. Otherwise, rendering a single text child will blow away non-preact-rendered children from a parent element.
developit
reviewed
Oct 15, 2024
Comment on lines
+501
to
+516
| } else if (typeof newChildren === 'string') { | ||
| if (newChildren !== oldProps.children) { | ||
| while (oldVNode._children && (i = oldVNode._children.pop())) { | ||
| // Setting textContent on the dom element will unmount all DOM nodes | ||
| // of the previous children, so we don't need to remove DOM in this | ||
| // call to unmount | ||
| unmount(i, oldVNode, true); | ||
| } | ||
|
|
||
| newVNode._children = [ | ||
| // @ts-expect-error | ||
| createVNode(null, (dom.textContent = newChildren), null, null) | ||
| ]; | ||
| // @ts-expect-error | ||
| newVNode._children[0]._dom = dom.firstChild; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else if (typeof newChildren === 'string') { | |
| if (newChildren !== oldProps.children) { | |
| while (oldVNode._children && (i = oldVNode._children.pop())) { | |
| // Setting textContent on the dom element will unmount all DOM nodes | |
| // of the previous children, so we don't need to remove DOM in this | |
| // call to unmount | |
| unmount(i, oldVNode, true); | |
| } | |
| newVNode._children = [ | |
| // @ts-expect-error | |
| createVNode(null, (dom.textContent = newChildren), null, null) | |
| ]; | |
| // @ts-expect-error | |
| newVNode._children[0]._dom = dom.firstChild; | |
| } | |
| } else if (typeof newChildren === 'string' && typeof oldProps.children === 'string') { | |
| if (newChildren !== oldProps.children) { | |
| oldVNode._children[0]._dom.data = newChildren; | |
| newVNode._children = oldVNode._children; | |
| oldVNode._children = []; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3939
Similar to 3939 we are seeing some operations take longer as rather than mutating the text-node we'll be swapping positions instead. The impact seems higher in skew based diff though so not sure whether the performance impact will be as high as in 3939.
The replace_1k difference is similar to #3939 (comment)
This could also be problematic with signals as text-updates won't automatically update afaik
Looks like this should not break signals actually
From #2618 we can derive that there are actually a lot of cases where the single child type is a text-node.