Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: oxlint v0.7.0 #4469

Merged
merged 1 commit into from
Aug 5, 2024
Merged

chore: oxlint v0.7.0 #4469

merged 1 commit into from
Aug 5, 2024

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Aug 5, 2024

  • Fixed some no-unused-vars in test directories
  • Removed confusing ignore directories in .eslintignore

Thank you for using oxlint.

This is an effort of keeping our ecosystem CI green.

* Fixed some `no-unused-vars` in tests
* Removed confusing ignore directories in `.eslintignore`
@@ -27,7 +27,7 @@ const componentPromise = new Promise<{ default: typeof IsLazyFunctional }>(
const IsLazyFunc = React.lazy(() => componentPromise);

// Suspense using lazy component
class SuspensefulFunc extends React.Component {
class ReactSuspensefulFunc extends React.Component {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These has to be prefix given our ignore pattern

"varsIgnorePattern": "^h|React|createElement|Fragment$"

@JoviDeCroock JoviDeCroock merged commit ab743a9 into preactjs:main Aug 5, 2024
1 check passed
@JoviDeCroock
Copy link
Member

Thank you!

@coveralls
Copy link

Coverage Status

coverage: 99.486%. remained the same
when pulling 8b60b70 on Boshen:oxlint-v0.7.0
into 8d86fe1 on preactjs:main.

@Boshen Boshen deleted the oxlint-v0.7.0 branch August 5, 2024 07:34
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants