Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear pending state from repeated renders #3567

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jun 14, 2022

When we repeat a render as implemented in #3553, we need to clear new args/values to ensure that we don't repeat effects that don't result in a new state, this is needed for consistent rendering

Resolves #3569

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Size Change: +95 B (0%)

Total Size: 42.9 kB

Filename Size Change
hooks/dist/hooks.js 1.23 kB +29 B (2%)
hooks/dist/hooks.module.js 1.25 kB +33 B (2%)
hooks/dist/hooks.umd.js 1.32 kB +33 B (2%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.48 kB 0 B
compat/dist/compat.module.js 3.46 kB 0 B
compat/dist/compat.umd.js 3.53 kB 0 B
debug/dist/debug.js 3.01 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.09 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 307 B 0 B
dist/preact.js 4.03 kB 0 B
dist/preact.min.js 4.06 kB 0 B
dist/preact.module.js 4.05 kB 0 B
dist/preact.umd.js 4.1 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.446% when pulling e13e9db on pending-value into c77e628 on master.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New state-settling logic causes hooks + cleanup to fire unexpectedly
3 participants