Move preact-render-to-string to preact/server
#3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When styles object is empty don’t render style attribute
…of children in non-pretty mode. /cc @rauchg
- Try to mimic the Preact TSD.
- Example usage with `noImplicitAny` enabled:
import { render } from "preact-render-to-string";
- No idea if I've done it right but it seems to compile and hopefully
someone more knowledgeable can build on this.
|
Size Change: 0 B Total Size: 38.6 kB ℹ️ View Unchanged
|
marvinhagemeister
requested review from
developit,
andrewiggins and
JoviDeCroock
marvinhagemeister
force-pushed
the
render-to-string
branch
from
357b0d3
to
3f01d72
Compare
marvinhagemeister
force-pushed
the
render-to-string
branch
from
3f01d72
to
9c20a01
Compare
| { | ||
| "name": "preact-server", | ||
| "amdName": "preactServer", | ||
| "version": "5.1.20", |
There was a problem hiding this comment.
are we publishing this separately or are we going to keep this at its own version
There was a problem hiding this comment.
I think we can safely ignore this as the plan is to publish this as part of core and not as a separate package. The other addons have bogus version numbers to which don't match the same package. So far we haven't gotten an issue for that so I'm assuming that no tool reads it.
Co-authored-by: Jovi De Croock <[email protected]>
JoviDeCroock
approved these changes
Mar 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the https://github.com/preactjs/preact-render-to-string repo into core under
preact/server. All commits from that repo are preserved and all tags have been renamed toserver-x.x.x.On top of that there are a few commits that integrate the tooling into our main one. It has not been updated for internals yet, so I've skipped a few tests. The tests can be run via
npm run test:mocha:server