Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move createPortal to core #3408

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Move createPortal to core #3408

merged 2 commits into from
Jan 13, 2022

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jan 11, 2022 •
edited
Loading

The implementation has grown to a very minimal amount of code so it seems worth moving this to Preact so importing createPortal doesn't require all the compat side-effects

@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +3% (-0.95ms - +2.89ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -1% - +2% (-1.01ms - +1.48ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-2.47ms - +10.39ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +1% (-0.54ms - +1.41ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -4% - +2% (-2.92ms - +1.75ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +3% (-5.53ms - +3.31ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +2% (-0.35ms - +1.31ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -1% - +1% (-0.56ms - +0.33ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +2% (-0.02ms - +0.04ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -3% - +2% (-0.04ms - +0.03ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -4% - +1% (-0.05ms - +0.01ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master103.51ms - 105.94ms-unsure 🔍
-3% - +1%
-2.89ms - +0.95ms
preact-local104.21ms - 107.18msunsure 🔍
-1% - +3%
-0.95ms - +2.89ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.02ms - 4.02ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local4.02ms - 4.03msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master49.12ms - 50.50ms-unsure 🔍
-2% - +2%
-1.08ms - +0.90ms
preact-local49.19ms - 50.62msunsure 🔍
-2% - +2%
-0.90ms - +1.08ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master60.50ms - 63.07ms-unsure 🔍
-5% - +2%
-2.87ms - +1.02ms
preact-local61.25ms - 64.17msunsure 🔍
-2% - +5%
-1.02ms - +2.87ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master52.74ms - 54.20ms-unsure 🔍
-2% - +1%
-1.34ms - +0.74ms
preact-local53.03ms - 54.51msunsure 🔍
-1% - +3%
-0.74ms - +1.34ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master42.06ms - 44.61ms-unsure 🔍
-3% - +4%
-1.45ms - +1.62ms
preact-local42.40ms - 44.10msunsure 🔍
-4% - +3%
-1.62ms - +1.45ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master53.14ms - 55.95ms-unsure 🔍
-6% - +0%
-3.68ms - +0.27ms
preact-local54.87ms - 57.63msunsure 🔍
-1% - +7%
-0.27ms - +3.68ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master103.54ms - 105.98ms-unsure 🔍
-3% - +1%
-2.88ms - +0.95ms
preact-local104.24ms - 107.21msunsure 🔍
-1% - +3%
-0.95ms - +2.88ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master79.19ms - 80.65ms-unsure 🔍
-2% - +1%
-1.48ms - +1.01ms
preact-local79.15ms - 81.17msunsure 🔍
-1% - +2%
-1.01ms - +1.48ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.05ms - 4.06ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.05ms - 4.06msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1143.58ms - 1151.26ms-unsure 🔍
-1% - +0%
-10.39ms - +2.47ms
preact-local1146.22ms - 1156.53msunsure 🔍
-0% - +1%
-2.47ms - +10.39ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master28.96ms - 28.96ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local28.96ms - 28.97msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master134.16ms - 135.32ms-unsure 🔍
-1% - +0%
-1.41ms - +0.54ms
preact-local134.38ms - 135.96msunsure 🔍
-0% - +1%
-0.54ms - +1.41ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.89ms - 1.94ms-unsure 🔍
-2% - +1%
-0.04ms - +0.02ms
preact-local1.91ms - 1.95msunsure 🔍
-1% - +2%
-0.02ms - +0.04ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master72.28ms - 75.69ms-unsure 🔍
-2% - +4%
-1.75ms - +2.92ms
preact-local71.80ms - 75.01msunsure 🔍
-4% - +2%
-2.92ms - +1.75ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.72ms - 6.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local6.72ms - 6.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master115.06ms - 121.59ms-unsure 🔍
-3% - +5%
-3.31ms - +5.53ms
preact-local114.24ms - 120.19msunsure 🔍
-5% - +3%
-5.53ms - +3.31ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.28ms - 6.28ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local6.28ms - 6.29msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master60.86ms - 61.69ms-unsure 🔍
-2% - +1%
-1.31ms - +0.35ms
preact-local61.04ms - 62.48msunsure 🔍
-1% - +2%
-0.35ms - +1.31ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.06ms - 1.10ms-unsure 🔍
-2% - +4%
-0.03ms - +0.04ms
preact-local1.05ms - 1.10msunsure 🔍
-3% - +2%
-0.04ms - +0.03ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-local
preact-master43.97ms - 44.73ms-unsure 🔍
-1% - +1%
-0.33ms - +0.56ms
preact-local44.00ms - 44.46msunsure 🔍
-1% - +1%
-0.56ms - +0.33ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.08ms - 1.12ms-unsure 🔍
-1% - +4%
-0.01ms - +0.05ms
preact-local1.06ms - 1.10msunsure 🔍
-4% - +1%
-0.05ms - +0.01ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

Size Change: +33 B (0%)

Total Size: 33.1 kB

Filename Size Change
compat/dist/compat.js 3.67 kB -16 B (0%)
compat/dist/compat.umd.js 3.74 kB -18 B (0%)
dist/preact.js 4.7 kB +18 B (0%)
dist/preact.min.js 4.76 kB +24 B (0%)
dist/preact.umd.js 4.81 kB +25 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.2 kB 0 B
debug/dist/debug.umd.js 3.3 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
hooks/dist/hooks.js 1.27 kB 0 B
hooks/dist/hooks.umd.js 1.34 kB 0 B
jsx-runtime/dist/jsxRuntime.js 342 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 425 B 0 B
test-utils/dist/testUtils.js 431 B 0 B
test-utils/dist/testUtils.umd.js 516 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.706% when pulling 57dece8 on portal-to-core into e2eddf9 on main.

developit
developit approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@JoviDeCroock JoviDeCroock merged commit 436afec into main Jan 13, 2022
@JoviDeCroock JoviDeCroock deleted the portal-to-core branch January 13, 2022 10:11
@github-actions github-actions bot mentioned this pull request Jan 13, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 16, 2022
Closed
@github-actions github-actions bot mentioned this pull request Sep 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @developit