Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ref types' current property non-optional #2803

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Make ref types' current property non-optional #2803

merged 1 commit into from
Oct 19, 2020

Conversation

ivantm
Copy link
Contributor

@ivantm ivantm commented Oct 18, 2020

This change aligns Preact's ref types with those of React, where the current property is not optional.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e0ca6d7 on ivantm:master into 9443406 on preactjs:master.

value: T,
formatter?: (value: T) => any
): void;
export function useDebugValue<T>(value: T, formatter?: (value: T) => any): void;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was prettier's doing.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks you so much for the PR 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants