Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "key" attribute handling when Component is the only child of anoher Component #255

Merged
merged 1 commit into from
Dec 2, 2016

Conversation

gnaeus
Copy link

@gnaeus gnaeus commented Aug 3, 2016

See #254

@developit
Copy link
Member

@gnaeus I'm holding off on merging this in 5.7 just yet because I think the issue might extend to DOM elements as well, not just components. Will get back to you shortly!

@developit developit modified the milestones: 5.7, 5.8 Aug 18, 2016
@developit
Copy link
Member

@gnaeus I believe this is fixed in 6.0.0 (beta). Let me know if you can confirm! 💯

@developit developit merged commit ef6142e into preactjs:master Dec 2, 2016
@gnaeus
Copy link
Author

gnaeus commented Dec 12, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants