feat: optimise jsx runtime (#4337)

* optimise jsx-runtime by only creating a new object when ref is passed * add test * shave * Update jsx-runtime/src/index.js Co-authored-by: Jason Miller <[email protected]> * fix --------- Co-authored-by: Jason Miller <[email protected]>
preactjs · Apr 17, 2024 · f3edc90 · f3edc90
1 parent 8c88f52
commit f3edc90
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/jsx-runtime/src/index.js b/jsx-runtime/src/index.js
@@ -27,17 +27,22 @@ const isArray = Array.isArray;
  * @param {unknown} [__self]
  */
 function createVNode(type, props, key, isStaticChildren, __source, __self) {
+	if (!props) props = {};
 	// We'll want to preserve `ref` in props to get rid of the need for
 	// forwardRef components in the future, but that should happen via
 	// a separate PR.
-	let normalizedProps = {},
+	let normalizedProps = props,
 		ref,
 		i;
-	for (i in props) {
-		if (i == 'ref') {
-			ref = props[i];
-		} else {
-			normalizedProps[i] = props[i];
+
+	if ('ref' in normalizedProps) {
+		normalizedProps = {};
+		for (i in props) {
+			if (i == 'ref') {
+				ref = props[i];
+			} else {
+				normalizedProps[i] = props[i];
+			}
 		}
 	}
 

diff --git a/jsx-runtime/test/browser/jsx-runtime.test.js b/jsx-runtime/test/browser/jsx-runtime.test.js
@@ -34,8 +34,16 @@ describe('Babel jsx/jsxDEV', () => {
 
 	it('should keep ref in props', () => {
 		const ref = () => null;
-		const vnode = jsx('div', { ref });
+		const props = { ref };
+		const vnode = jsx('div', props);
 		expect(vnode.ref).to.equal(ref);
+		expect(vnode.props).to.not.equal(props);
+	});
+
+	it('should not copy props wen there is no ref in props', () => {
+		const props = { x: 'y' };
+		const vnode = jsx('div', props);
+		expect(vnode.props).to.equal(props);
 	});
 
 	it('should add keys', () => {