add delay by 1 microtick (#4005)

preactjs · May 16, 2023 · bcf365b · bcf365b
1 parent 8fe5401
commit bcf365b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/compat/src/render.js b/compat/src/render.js
@@ -118,10 +118,10 @@ options.event = e => {
  */
 function afterEvent(eventType, target) {
 	if (target.value != null) {
-		target.value = target._prevValue;
+		Promise.resolve().then(() => (target.value = target._prevValue));
 	}
 	if (eventType === 'change' && target.checked != null) {
-		target.checked = target._prevValue;
+		Promise.resolve().then(() => (target.checked = target._prevValue));
 	}
 }
 

diff --git a/compat/test/browser/controlledInput.test.js b/compat/test/browser/controlledInput.test.js
@@ -168,7 +168,7 @@ describe('preact/compat controlled inputs', () => {
 		render(<Input />, scratch);
 
 		scratch.firstChild.value = 'A';
-		fireEvent(scratch.firstChild, 'change');
+		await fireEvent(scratch.firstChild, 'change');
 		expect(calls).to.deep.equal(['A']);
 		expect(scratch.firstChild.value).to.equal('A');
 
@@ -208,6 +208,8 @@ describe('preact/compat controlled inputs', () => {
 
 		scratch.firstChild.checked = false;
 		await fireEvent(scratch.firstChild, 'change');
+		// Have to wait for the microtick
+		await new Promise(res => setTimeout(res));
 		expect(calls).to.deep.equal([false]);
 		expect(scratch.firstChild.checked).to.equal(true);
 	});