Improve performance and reduce memory allocation

preactjs · Oct 2, 2024 · 5de3be2 · 5de3be2
1 parent 6a66daa
commit 5de3be2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/compat/src/forwardRef.js b/compat/src/forwardRef.js
@@ -1,5 +1,4 @@
 import { options } from 'preact';
-import { assign } from './util';
 
 let oldDiffHook = options._diff;
 options._diff = vnode => {
@@ -25,9 +24,15 @@ export const REACT_FORWARD_SYMBOL =
  */
 export function forwardRef(fn) {
 	function Forwarded(props) {
-		let clone = assign({}, props);
-		delete clone.ref;
-		return fn(clone, props.ref || null);
+		if (!('ref' in props)) return fn(props, null);
+
+		let ref = props.ref;
+		try {
+			delete props.ref;
+			return fn(props, ref || null);
+		} finally {
+			props.ref = ref;
+		}
 	}
 
 	// mobx-react checks for this being present

diff --git a/jsx-runtime/src/index.js b/jsx-runtime/src/index.js
@@ -35,15 +35,9 @@ function createVNode(type, props, key, isStaticChildren, __source, __self) {
 		ref,
 		i;
 
-	if ('ref' in normalizedProps) {
-		normalizedProps = {};
-		for (i in props) {
-			if (i == 'ref') {
-				ref = props[i];
-			} else {
-				normalizedProps[i] = props[i];
-			}
-		}
+	if ('ref' in props) {
+		ref = props.ref;
+		delete props.ref;
 	}
 
 	/** @type {VNode & { __source: any; __self: any }} */

diff --git a/jsx-runtime/test/browser/jsx-runtime.test.js b/jsx-runtime/test/browser/jsx-runtime.test.js
@@ -37,7 +37,8 @@ describe('Babel jsx/jsxDEV', () => {
 		const props = { ref };
 		const vnode = jsx('div', props);
 		expect(vnode.ref).to.equal(ref);
-		expect(vnode.props).to.not.equal(props);
+		expect(vnode.props).to.equal(props);
+		expect(vnode.props.ref).to.equal(undefined);
 	});
 
 	it('should not copy props wen there is no ref in props', () => {