Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<input type='checkbox' checked={false} /> not rendered properly. #2

Closed
dtinth opened this issue Mar 10, 2016 · 2 comments
Closed

<input type='checkbox' checked={false} /> not rendered properly. #2

dtinth opened this issue Mar 10, 2016 · 2 comments
Labels
bug
Milestone
2.1.0

Comments

@dtinth
Copy link

dtinth commented Mar 10, 2016

Expected result

<input type="checkbox">

Actual result

<input type="checkbox" checked="false"></input>

Note that this HTML code generates a checkbox that is checked, because the presence of the checked attribute.
@developit
Copy link
Member

Good catch, I'll get a fix in for this right away. Thanks!

developit added a commit that referenced this issue Mar 11, 2016
@developit
Skip falsey attributes and children - fixes Issue #2
5abad70
@developit developit added the bug label Mar 11, 2016
@developit developit added this to the 2.1.0 milestone Mar 11, 2016
@developit
Copy link
Member

Fixed and release in 2.1.0.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@developit @dtinth