-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump Preact version #490
Conversation
Didn't realize Edit: Ah, falling prey to the (breaking) change in |
@@ -165,7 +165,7 @@ | |||
z-index: 2; | |||
} | |||
|
|||
.icon-btn:not([disabled])[data-active] .icon-btn-inner, | |||
.icon-btn:not([disabled])[data-active="true"] .icon-btn-inner, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helpful ripgrep pattern: $ rg 'data-[\w-]+]'
Should be good to go. It was indeed the breaking change in data attributes & the addition of |
@marvinhagemeister Just FYI, I'm not on the authorized users list here so I cannot merge. Absolutely 0 rush to land this, I've switch the CI over to use this branch anyhow so it'll catch any future changes in Preact that may affect this repo, just wanted to mention it in case the intention was that I could merge whenever I thought it was good. |
Devtools is failing on the ecosystem-ci I had set up.
Two issues:
preact/src/internal
to wrap all of the interfaces indeclare global
, so we can no longer access them directlypatch-package
for the moment. Happy to go with whatever you prefer, I absolutely can copy the types here if you'd like, import and use those types as globals, etc., just thought I'd throw out this approach first as it's the simplest and probably most straightforward.h()
calls, so a couple of the tests where you add arbitrary props (foo
,__source
) now fail type checks.