Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support checking unicode TOML #479

Merged
merged 1 commit into from
May 17, 2020
Merged

Support checking unicode TOML #479

merged 1 commit into from
May 17, 2020

Conversation

mxr
Copy link
Member

@mxr mxr commented May 17, 2020

Resolves #474

asottile
asottile reviewed May 17, 2020
View reviewed changes
tests/check_toml_test.py Outdated Show resolved Hide resolved
@mxr mxr force-pushed the fix-encoding branch 3 times, most recently from db59242 to 9fd5b16 Compare May 17, 2020 01:02
mxr
mxr commented May 17, 2020
View reviewed changes
pre_commit_hooks/check_toml.py Outdated Show resolved Hide resolved
@mxr mxr changed the title Specify encoding in open() call Support checking unicode TOML May 17, 2020
asottile
asottile approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit ddf5e94 into pre-commit:master May 17, 2020
@mxr mxr deleted the fix-encoding branch May 17, 2020 01:28
@staticdev
Copy link

@mxr something strange.. I pointed my repo to v3.0.1 with your fix and I am getting the same error: staticdev/toml-validator#30

@asottile
Copy link
Member

@staticdev I see

Check Toml...............................................................Passed

you have a failure in prettier though 😉

@staticdev
Copy link

Wow.. I am sorry! I just realized that.

@staticdev staticdev mentioned this pull request May 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug check-toml ASCII on Windows
3 participants
@mxr @staticdev @asottile