Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Indentify metal as Metal Shading Language #441

Merged
merged 1 commit into from
Feb 18, 2024
Merged

feat: Indentify metal as Metal Shading Language #441

merged 1 commit into from
Feb 18, 2024

Conversation

Maetveis
Copy link
Contributor

@Maetveis Maetveis commented Feb 8, 2024

Metal Programming guide: Metal Tools

File Extension for Metal Shading Language Source Files

For Metal shading language source code file names, you must use the
.metal file name extension to ensure that the development tools
(Xcode and the GPU frame debugger) recognize the source files when
debugging or profiling.

identify/extensions.py Outdated Show resolved Hide resolved
@Maetveis Maetveis requested a review from asottile February 12, 2024 18:35
@asottile
Copy link
Member

I can't fix your PR because you made it from a organization -- can you fix it for me?

@Maetveis
Copy link
Contributor Author

I can't fix your PR because you made it from a organization -- can you fix it for me?

I changed the file, should I rewrite the commit message too?

@asottile
Copy link
Member

right now you have two commits with identical messages

@Maetveis Maetveis closed this Feb 18, 2024
Metal Programming guide: Metal Tools

> ## File Extension for Metal Shading Language Source Files
>
> For Metal shading language source code file names, you must use the
> .metal file name extension to ensure that the development tools
> (Xcode and the GPU frame debugger) recognize the source files when
> debugging or profiling.
@Maetveis Maetveis reopened this Feb 18, 2024
@Maetveis
Copy link
Contributor Author

Maetveis commented Feb 18, 2024

right now you have two commits with identical messages

Whoops, right. Should be fixed now, ignore the random close: I messed up the rebase at one point and GitHub likes to automatically close stuff when it has no commits seems like.

@asottile asottile merged commit 6358894 into pre-commit:main Feb 18, 2024
9 checks passed
@Maetveis Maetveis deleted the metal-shading-language branch February 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants