Add option to ColumnBox to support resetting to parents top margin on new page. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for page title text on the first page that is not repeated on every page. The default is off, so it is completely backward compatible. I also added a spec to verify the existing behavior (which was not previously tested) and a spec to for the new option.
ghost
assigned 
|
@phurley: Can you post a comment with some example code that demonstrates the use case? |
|
Closing, but will re-open once I see an example. (Tagged as needs-revisions so others can find it, too) |
|
Hi, I merged a slightly modified version of this patch into master -- it makes sure to use absolute rather than relative coordinates, which will avoid adding extra space on pages with non-zero margins. Please give master a try and see if it works as you'd expect! |
|
Commit: 3610f91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for page title text on the first page that is not repeated
on every page. The default is off, so it is completely backward
compatible. I also added a spec to verify the existing behavior
(which was not previously tested) and a spec to for the new option.